This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Test/mkldnn batch norm op #13084
Closed
Test/mkldnn batch norm op #13084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azai91
force-pushed
the
test/mkldnn-batch-norm-op
branch
from
287c577
to
60723de
Compare
|
@TaoLv please review |
|
@azai91 It will be helpful if you can please add more details to description explaining why tests where failing earlier, and how did you fix it. |
|
@mseth10 @anirudh2290 pulling you guys in for a review... |
|
@Vikas89 added |
|
Is it possible to separate operator change and unit test into two PRs? |
anirudh2290
reviewed
Dec 13, 2018
| bool inputs_valid = SupportMKLDNN(inputs[0]); | ||
| for (size_t i = 1; i < inputs.size(); i++) { | ||
| if (inputs[i].IsMKLDNNData()) { | ||
| inputs_valid = false; |
There was a problem hiding this comment.
inputs valid is set to false if it is in MKLDNN format ?
mseth10
reviewed
Dec 13, 2018
| && param.axis == mxnet::op::batchnorm::DEFAULT_AXIS | ||
| && shape[param.axis] % 8 == 0 | ||
| && !mxnet::op::batchnorm::disable_mkl; | ||
| bool inputs_valid = SupportMKLDNN(inputs[0]); | ||
| for (size_t i = 1; i < inputs.size(); i++) { | ||
| if (inputs[i].IsMKLDNNData()) { |
There was a problem hiding this comment.
Once inputs_valid is set to false, we need not check remaining inputs, we can add a break here.
if (!inputs_valid) break;
|
@azai91 can you please resolve merge conflicts. |
|
@azai91 - can you please rebase? |
|
@azai91 please rebase and resolve merge conflicts |
|
closing since this is a duplicate of #13625 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests for MKLDNN batch norm operator The creates ndarray inputs and then runs it separately through the native CPU BN operator and MKLDNN BN operator. Creating the BN test requires a different helper as the BN operation writes to the input, so identical arrays of equal value must be created and then ran through the native / MKLDNN operators.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments