Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix race condition in engine start/stop #8995

Merged
merged 1 commit into from
Dec 8, 2017
Merged

Fix race condition in engine start/stop #8995

merged 1 commit into from
Dec 8, 2017

Conversation

piiswrong
Copy link
Contributor

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • For user-facing API changes, API doc string has been updated. For new C++ functions in header files, their functionalities and arguments are well-documented.
  • To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@zhreshold
Copy link
Member

Fixed an issue for me. 👍

eric-haibin-lin
eric-haibin-lin reviewed Dec 8, 2017
View reviewed changes
Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to create a test case to prevent this from happening in the future?

@szha
Copy link
Member

szha commented Dec 8, 2017

Given that it’s urgently needed, I’m merging. I agree that tests should be added for catching this if feasible.

@szha szha merged commit 5c11ecd into apache:master Dec 8, 2017
eric-haibin-lin pushed a commit that referenced this pull request Dec 8, 2017
@piiswrong @eric-haibin-lin
Fix race condition in engine start/stop (#8995)
0f05c65
zhreshold pushed a commit to zhreshold/mxnet that referenced this pull request Dec 14, 2017
@piiswrong @zhreshold
Fix race condition in engine start/stop (apache#8995)
a1a5f7d
@safrooze safrooze mentioned this pull request Feb 14, 2018
Closed
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
@piiswrong @szha
Fix race condition in engine start/stop (apache#8995)
43318e0
This was referenced Jun 13, 2018
Merged
Merged
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@piiswrong @zheng-da
Fix race condition in engine start/stop (apache#8995)
3f8c019
@Roshrini Roshrini mentioned this pull request Aug 16, 2018
Open
@fhieber fhieber mentioned this pull request Oct 1, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-haibin-lin eric-haibin-lin eric-haibin-lin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piiswrong @zhreshold @szha @eric-haibin-lin