Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix multi worker dataloader deadlock #9126

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Conversation

piiswrong
Copy link
Contributor

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@piiswrong piiswrong merged commit 500ed5f into apache:master Dec 19, 2017
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

szha pushed a commit that referenced this pull request Dec 19, 2017
@fpshuang
Copy link

Sry for my poor English translation skills, I'd write this in Chinese.

大佬,我在运行你的天池比赛样例的时候,在第十三个代码块中,运行时发生错误:local variable 'idx' referenced before assignment
错误提示如下
/usr/lib/python2.7/site-packages/mxnet/gluon/data/dataloader.pyc in iter(self)
217 for idx, batch in enumerate(self._batch_sampler):
218 key_queue.put((idx, batch))
--> 219 num_batches = idx + 1
220
221 data_buffer = {}

私以为num_batches = idx + 1应该tab间隔一下,以便作为for loop中进行操作,希望得到大佬的解答。

rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants