Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix float16 min and max #9149

Merged
merged 2 commits into from
Dec 20, 2017
Merged

Conversation

reminisce
Copy link
Contributor

@reminisce reminisce commented Dec 19, 2017

Description

Added the commit in mshadow: dmlc/mshadow#315
Fixed this issue: #9007

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • [] Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@reminisce reminisce changed the title [WIP] Fix float16 min and max Fix float16 min and max Dec 20, 2017
@piiswrong piiswrong merged commit 080d29c into apache:master Dec 20, 2017
@szha szha added the Bug label Dec 20, 2017
szha pushed a commit that referenced this pull request Dec 22, 2017
* Add unittest for float16 min and max

* Add mshadow fix
meissnereric pushed a commit to meissnereric/incubator-mxnet that referenced this pull request Jan 2, 2018
* Add unittest for float16 min and max

* Add mshadow fix
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
* Add unittest for float16 min and max

* Add mshadow fix
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* Add unittest for float16 min and max

* Add mshadow fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants