Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Refactor scala code/tests/examples/docs to use org.apache.mxnet #9324

Merged
merged 3 commits into from
Jan 7, 2018
Merged

Refactor scala code/tests/examples/docs to use org.apache.mxnet #9324

merged 3 commits into from
Jan 7, 2018

Conversation

Roshrini
Copy link
Member

@Roshrini Roshrini commented Jan 5, 2018 •
edited
Loading

Description

Refactor scala code/tests/examples/docs to use org.apache.mxnet instead of ml.dmlc.mxnet
#9315
@nswamy @Javelinjs

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Roshrini Roshrini requested a review from yzhliu as a code owner January 5, 2018 17:59
nswamy
nswamy reviewed Jan 5, 2018
View reviewed changes
docs/api/scala/model.md Outdated
@@ -10,7 +10,7 @@ Topics:
* [Save the Model](#save-the-model)
* [Periodic Checkpoint](#periodic-checkpointing)
* [Multiple Devices](#use-multiple-devices)
* [Model API Reference](#http://mxnet.io/api/scala/docs/index.html#ml.dmlc.mxnet.Model)
* [Model API Reference](#http://mxnet.io/api/scala/docs/index.html#org.apache.mxnet.Model)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please point the links to mxnet.apache.org

@yzhliu yzhliu merged commit deb25bc into apache:master Jan 7, 2018
yuxiangw pushed a commit to yuxiangw/incubator-mxnet that referenced this pull request Jan 25, 2018
@Roshrini @yuxiangw
Refactor scala code/tests/examples/docs to use org.apache.mxnet (apac…
6af4c75 
…he#9324)

* refactor scala code/tests/examples/docs to use org.apache.mxnet
nswamy added a commit to nswamy/incubator-mxnet that referenced this pull request Jan 26, 2018
@nswamy
Reverting namespace change since this needs a major version change an…
7986078 
…d breaks backward compatibility.

Revert "Refactor scala code/tests/examples/docs to use org.apache.mxnet (apache#9324)"

This reverts commit deb25bc.
@nswamy nswamy mentioned this pull request Jan 26, 2018
Merged
7 tasks
yzhliu pushed a commit that referenced this pull request Jan 27, 2018
@nswamy @yzhliu
Reverting namespace change since this needs a major version change an…
671df77 
…d breaks backward compatibility. (#9579)

Revert "Refactor scala code/tests/examples/docs to use org.apache.mxnet (#9324)"

This reverts commit deb25bc.
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
@Roshrini @yzhliu
Refactor scala code/tests/examples/docs to use org.apache.mxnet (apac…
6bda760 
…he#9324)

* refactor scala code/tests/examples/docs to use org.apache.mxnet
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
@nswamy @yzhliu
Reverting namespace change since this needs a major version change an…
c397396 
…d breaks backward compatibility. (apache#9579)

Revert "Refactor scala code/tests/examples/docs to use org.apache.mxnet (apache#9324)"

This reverts commit deb25bc.
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@Roshrini @zheng-da
Refactor scala code/tests/examples/docs to use org.apache.mxnet (apac…
108b109 
…he#9324)

* refactor scala code/tests/examples/docs to use org.apache.mxnet
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@nswamy @zheng-da
Reverting namespace change since this needs a major version change an…
45685de 
…d breaks backward compatibility. (apache#9579)

Revert "Refactor scala code/tests/examples/docs to use org.apache.mxnet (apache#9324)"

This reverts commit deb25bc.
@Roshrini Roshrini deleted the scala-code branch November 15, 2018 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nswamy nswamy nswamy left review comments

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Roshrini @nswamy @yzhliu