hw/mcu/stm32: Fix WFI in RAM for -O3 #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though function stm32_wfi_from_ram() has attribute to be placed in ram in -03 it can be inlined that can effectively run WFI from flash. Now additional attribute is added to make sure that it is not inlined. bx lr is also removed allowing compiler to make normal exit from function (which in most cases will be bx lr) Signed-off-by: Jerzy Kasenberg <jerzy@apache.org>
sjanc
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though function stm32_wfi_from_ram() has attribute to be placed in ram in -03 it can be inlined that can effectively run WFI from flash.
Now additional attribute is added to make sure that it is not inlined.
bx lr is also removed allowing compiler to make normal exit from function (which in most cases will be bx lr)