RATIS-1368 Fix server impl NPEs #470
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softgitron
changed the title
runzhiwang
reviewed
May 14, 2021
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
Outdated
Show resolved
Hide resolved
runzhiwang
reviewed
May 14, 2021
| @@ -1633,7 +1645,7 @@ void submitUpdateCommitEvent() { | |||
| // update the retry cache | |||
| final CacheEntry cacheEntry = retryCache.getOrCreateEntry(invocationId); | |||
| if (getInfo().isLeader()) { | |||
| Preconditions.assertTrue(cacheEntry != null && !cacheEntry.isCompletedNormally(), | |||
| Preconditions.assertTrue(!cacheEntry.isCompletedNormally(), | |||
There was a problem hiding this comment.
why remove cacheEntry != null ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix three NPE issues reported by Sonar Qube in the server impl.
Was part of the #461
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1368
How was this patch tested?
Changes have been tested using existing test cases and two new test cases.