[SPARK-49415][CONNECT][SQL] Move SQLImplicits to sql/api #48151
+347
−603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Sep 18, 2024
hvanhovell
commented
Sep 19, 2024
| } | ||
|
|
||
| /** @since 1.6.1 */ | ||
| implicit def newIntArrayEncoder: Encoder[Array[Int]] = newArrayEncoder(PrimitiveIntEncoder) |
There was a problem hiding this comment.
These should be vals
hvanhovell
commented
Sep 19, 2024
| implicit def newPeriodEncoder: Encoder[java.time.Period] = Encoders.PERIOD | ||
|
|
||
| /** @since 3.2.0 */ | ||
| implicit def newJavaEnumEncoder[A <: java.lang.Enum[_]: TypeTag]: Encoder[A] = |
There was a problem hiding this comment.
This could be faster. There is no need to use ScalaReflection here.
hvanhovell
commented
Sep 19, 2024
| /** @since 1.6.0 */ | ||
| implicit def newProductEncoder[T <: Product : TypeTag]: Encoder[T] = Encoders.product[T] | ||
|
|
||
| implicit def rddToDatasetHolder[T : Encoder](rdd: RDD[T]): DatasetHolder[T, Dataset] = |
There was a problem hiding this comment.
I will move this as soon as the shims land.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR largely moves SQLImplicits and DatasetHolder to sql/api.
Why are the changes needed?
We are creating a unified Scala interface for Classic and Connect.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.