fix(explore): Incorrect conversion from simple bool filter to custom …

…sql (#21293)
apache · Sep 1, 2022 · 076af60 · 076af60
1 parent eb80568
commit 076af60
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/superset-frontend/src/utils/common.js b/superset-frontend/src/utils/common.js
@@ -66,10 +66,10 @@ export function optionLabel(opt) {
     return EMPTY_STRING;
   }
   if (opt === true) {
-    return '<true>';
+    return TRUE_STRING;
   }
   if (opt === false) {
-    return '<false>';
+    return FALSE_STRING;
   }
   if (typeof opt !== 'string' && opt.toString) {
     return opt.toString();

diff --git a/superset-frontend/src/utils/common.test.jsx b/superset-frontend/src/utils/common.test.jsx
@@ -21,16 +21,21 @@ import {
   optionFromValue,
   prepareCopyToClipboardTabularData,
   NULL_STRING,
+  TRUE_STRING,
+  FALSE_STRING,
 } from 'src/utils/common';
 
 describe('utils/common', () => {
   describe('optionFromValue', () => {
     it('converts values as expected', () => {
       expect(optionFromValue(false)).toEqual({
         value: false,
-        label: '<false>',
+        label: FALSE_STRING,
+      });
+      expect(optionFromValue(true)).toEqual({
+        value: true,
+        label: TRUE_STRING,
       });
-      expect(optionFromValue(true)).toEqual({ value: true, label: '<true>' });
       expect(optionFromValue(null)).toEqual({
         value: NULL_STRING,
         label: NULL_STRING,