Skip to content

Commit

Permalink
fix: datasourcedao datasource not found error (#20725)
Browse files Browse the repository at this point in the history
* first fix

* remove prints

* run pc

* fix linter

* commit
  • Loading branch information
pkdotson authored Jul 19, 2022
1 parent 84d4302 commit 1d9d505
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
8 changes: 8 additions & 0 deletions superset/datasource/dao.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
# specific language governing permissions and limitations
# under the License.

import logging
from typing import Dict, Type, Union

from sqlalchemy.orm import Session
Expand All @@ -27,6 +28,8 @@
from superset.tables.models import Table
from superset.utils.core import DatasourceType

logger = logging.getLogger(__name__)

Datasource = Union[Dataset, SqlaTable, Table, Query, SavedQuery]


Expand Down Expand Up @@ -57,6 +60,11 @@ def get_datasource(
)

if not datasource:
logger.warning(
"Datasource not found datasource_type: %s, datasource_id: %s",
datasource_type,
datasource_id,
)
raise DatasourceNotFound()

return datasource
2 changes: 1 addition & 1 deletion superset/views/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ def explore(
try:
datasource = DatasourceDAO.get_datasource(
db.session,
DatasourceType(cast(str, datasource_type)),
DatasourceType("table"),
datasource_id,
)
except DatasetNotFoundError:
Expand Down

0 comments on commit 1d9d505

Please sign in to comment.