Skip to content

Commit

Permalink
chore: add certified columns to top of list (#16910)
Browse files Browse the repository at this point in the history
* initial commit

* inital commit

* add suggestions

* remove changes

* Update superset-frontend/src/explore/components/DatasourcePanel/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
  • Loading branch information
pkdotson and michael-s-molina authored Oct 1, 2021
1 parent 420eff4 commit 3f6a24f
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions superset-frontend/src/explore/components/DatasourcePanel/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@
* under the License.
*/
import React, { useEffect, useMemo, useRef, useState } from 'react';
import { ControlConfig, DatasourceMeta } from '@superset-ui/chart-controls';
import {
ControlConfig,
DatasourceMeta,
ColumnMeta,
} from '@superset-ui/chart-controls';
import { debounce } from 'lodash';
import { matchSorter, rankings } from 'match-sorter';
import { css, styled, t } from '@superset-ui/core';
Expand Down Expand Up @@ -253,6 +257,9 @@ export default function DataSourcePanel({
setInputValue('');
}, [columns, datasource, metrics]);

const sortCertifiedFirst = (slice: ColumnMeta[]) =>
slice.sort((a, b) => b.is_certified - a.is_certified);

const metricSlice = useMemo(
() =>
showAllMetrics
Expand All @@ -263,8 +270,10 @@ export default function DataSourcePanel({
const columnSlice = useMemo(
() =>
showAllColumns
? lists.columns
: lists.columns.slice(0, DEFAULT_MAX_COLUMNS_LENGTH),
? sortCertifiedFirst(lists.columns)
: sortCertifiedFirst(
lists.columns.slice(0, DEFAULT_MAX_COLUMNS_LENGTH),
),
[lists.columns, showAllColumns],
);

Expand Down

0 comments on commit 3f6a24f

Please sign in to comment.