Skip to content

Commit

Permalink
Save Dataset Modal:
Browse files Browse the repository at this point in the history
- Stop clearing the selected dataset after overwritting so users can overwrite as many times as they see fit
- There's a new AsyncSelect we should use now
  • Loading branch information
Antonio-RiveroMartnez committed Jul 12, 2022
1 parent ff5b4bc commit 52f099b
Showing 1 changed file with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

import React, { FunctionComponent, useCallback, useState } from 'react';
import { Radio } from 'src/components/Radio';
import { RadioChangeEvent, Select } from 'src/components';
import { RadioChangeEvent, AsyncSelect } from 'src/components';
import { Input } from 'src/components/Input';
import StyledModal from 'src/components/Modal';
import Button from 'src/components/Button';
Expand Down Expand Up @@ -158,7 +158,7 @@ export const SaveDatasetModal: FunctionComponent<SaveDatasetModalProps> = ({
is_dttm: d.is_dttm,
}),
),
datasetToOverwrite.owners.map((o: DatasetOwner) => o.id),
datasetToOverwrite.owners?.map((o: DatasetOwner) => o.id),
true,
),
postFormData(datasetToOverwrite.datasetid, 'table', {
Expand All @@ -178,7 +178,6 @@ export const SaveDatasetModal: FunctionComponent<SaveDatasetModalProps> = ({
window.open(url, '_blank', 'noreferrer');

setShouldOverwriteDataset(false);
setDatasetToOverwrite({});
setDatasetName(getDefaultDatasetName());
};

Expand Down Expand Up @@ -359,7 +358,7 @@ export const SaveDatasetModal: FunctionComponent<SaveDatasetModalProps> = ({
{t('Overwrite existing')}
</Radio>
<div className="sdm-autocomplete">
<Select
<AsyncSelect
allowClear
showSearch
placeholder={t('Select or type dataset name')}
Expand Down

0 comments on commit 52f099b

Please sign in to comment.