fix(sqllab): Fix autocomplete for SQL Lab (#22329)

apache · Dec 5, 2022 · 96de314 · 96de314
1 parent 5e1b817
commit 96de314
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/superset-frontend/src/SqlLab/components/SqlEditorLeftBar/SqlEditorLeftBar.test.jsx b/superset-frontend/src/SqlLab/components/SqlEditorLeftBar/SqlEditorLeftBar.test.jsx
@@ -110,8 +110,8 @@ test('should toggle the table when the header is clicked', async () => {
   userEvent.click(header);
 
   await waitFor(() => {
-    expect(store.getActions()).toHaveLength(2);
-    expect(store.getActions()[1].type).toEqual('COLLAPSE_TABLE');
+    expect(store.getActions()).toHaveLength(4);
+    expect(store.getActions()[3].type).toEqual('COLLAPSE_TABLE');
   });
 });
 

diff --git a/superset-frontend/src/components/TableSelector/index.tsx b/superset-frontend/src/components/TableSelector/index.tsx
@@ -185,8 +185,7 @@ const TableSelector: FunctionComponent<TableSelectorProps> = ({
   } = useTables({
     dbId: database?.id,
     schema: currentSchema,
-    onSuccess: (data: { options: Table[] }) => {
-      onTablesLoad?.(data.options);
+    onSuccess: () => {
       if (isFetched) {
         addSuccessToast(t('List updated'));
       }
@@ -203,6 +202,14 @@ const TableSelector: FunctionComponent<TableSelectorProps> = ({
     },
   });
 
+  useEffect(() => {
+    // Set the tableOptions in the queryEditor so autocomplete
+    // works on new tabs
+    if (data && isFetched) {
+      onTablesLoad?.(data.options);
+    }
+  }, [data, isFetched, onTablesLoad]);
+
   const tableOptions = useMemo<TableOption[]>(
     () =>
       data