Skip to content

Commit

Permalink
Clean up code
Browse files Browse the repository at this point in the history
  • Loading branch information
lyndsiWilliams committed Aug 4, 2022
1 parent 1c6c336 commit 9f348bd
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ export const SaveDatasetModal: FunctionComponent<SaveDatasetModalProps> = ({
openWindow = true,
formData = {},
}) => {
console.log('FINDME SaveDatasetModal', datasource);
const defaultVizType = useSelector<SqlLabRootState, string>(
state => state.common?.conf?.DEFAULT_VIZ_TYPE || 'table',
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ export default function SaveQuery({
</Form>
);

console.log('FINDME SaveQuery', query, queryPayload());
return (
<Styles className="SaveQuery">
<SaveDatasetActionButton
Expand Down
10 changes: 4 additions & 6 deletions superset-frontend/src/SqlLab/components/SqlEditor/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -663,11 +663,6 @@ class SqlEditor extends React.PureComponent {
</Menu>
);

const queryWithColumns = () => ({
...qe,
columns: this.props.latestQuery?.results?.columns || [],
});
console.log('findme SqlEditor', qe, queryWithColumns());
return (
<StyledToolbar className="sql-toolbar" id="js-sql-toolbar">
<div className="leftItems">
Expand Down Expand Up @@ -726,7 +721,10 @@ class SqlEditor extends React.PureComponent {
<div className="rightItems">
<span>
<SaveQuery
query={queryWithColumns()}
query={{
...qe,
columns: this.props.latestQuery?.results?.columns || [],
}}
defaultLabel={qe.name || qe.description}
onSave={this.saveQuery}
onUpdate={this.props.actions.updateSavedQuery}
Expand Down

0 comments on commit 9f348bd

Please sign in to comment.