Uses CROSS_REFERENCES feature flag

apache · Oct 6, 2022 · b0c5e8f · b0c5e8f
1 parent 687ae58
commit b0c5e8f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 10 deletions.
diff --git a/superset-frontend/src/explore/components/ExploreChartHeader/index.jsx b/superset-frontend/src/explore/components/ExploreChartHeader/index.jsx
@@ -24,6 +24,8 @@ import { Tooltip } from 'src/components/Tooltip';
 import {
   CategoricalColorNamespace,
   css,
+  FeatureFlag,
+  isFeatureEnabled,
   logging,
   SupersetClient,
   t,
@@ -164,7 +166,8 @@ export const ExploreChartHeader = ({
           ? t('Added to %s dashboard(s)', metadata.dashboards.length)
           : t('Not added to any dashboard'),
       description:
-        metadata.dashboards.length > 0
+        metadata.dashboards.length > 0 &&
+        isFeatureEnabled(FeatureFlag.CROSS_REFERENCES)
           ? t(
               'To preview the list of dashboards go to "more" settings on the right.',
             )

diff --git a/superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx b/superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx
@@ -255,15 +255,17 @@ export const useExploreAdditionalActionsMenu = (
               {t('Edit chart properties')}
             </Menu.Item>
           )}
-          <Menu.SubMenu
-            title={t('Dashboards added to')}
-            key={MENU_KEYS.DASHBOARDS_ADDED_TO}
-          >
-            <DashboardsSubMenu
-              chartId={slice?.slice_id}
-              dashboards={dashboards}
-            />
-          </Menu.SubMenu>
+          {isFeatureEnabled(FeatureFlag.CROSS_REFERENCES) && (
+            <Menu.SubMenu
+              title={t('Dashboards added to')}
+              key={MENU_KEYS.DASHBOARDS_ADDED_TO}
+            >
+              <DashboardsSubMenu
+                chartId={slice?.slice_id}
+                dashboards={dashboards}
+              />
+            </Menu.SubMenu>
+          )}
           <Menu.Divider />
         </>
         <Menu.SubMenu title={t('Download')} key={MENU_KEYS.DOWNLOAD_SUBMENU}>

diff --git a/tests/integration_tests/superset_test_config.py b/tests/integration_tests/superset_test_config.py
@@ -71,6 +71,7 @@
     "ALERT_REPORTS": True,
     "DASHBOARD_NATIVE_FILTERS": True,
     "DRILL_TO_DETAIL": True,
+    "CROSS_REFERENCES": True,
 }
 
 WEBDRIVER_BASEURL = "http://0.0.0.0:8081/"