remove config

apache · Mar 15, 2022 · bba129f · bba129f
1 parent e3e03d2
commit bba129f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/SqlAlchemyForm.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/SqlAlchemyForm.tsx
@@ -45,7 +45,10 @@ const SqlAlchemyTab = ({
     fallbackDocsUrl =
       SupersetText.DB_MODAL_SQLALCHEMY_FORM?.SQLALCHEMY_DOCS_URL;
     fallbackDisplayText =
-      SupersetText.DB_MODAL_SQLALCHEMY_FORM?.SQLALCHEMY_DOCS_URL;
+      SupersetText.DB_MODAL_SQLALCHEMY_FORM?.SQLALCHEMY_DISPLAY_TEXT;
+  } else {
+    fallbackDocsUrl = 'https://docs.sqlalchemy.org/en/13/core/engines.html';
+    fallbackDisplayText = 'SQLAlchemy docs';
   }
   return (
     <>

diff --git a/superset/config.py b/superset/config.py
@@ -1336,10 +1336,6 @@ def SQL_QUERY_MUTATOR(  # pylint: disable=invalid-name,unused-argument
 # Do not show user info or profile in the menu
 MENU_HIDE_USER_INFO = False
 
-# SQLalchemy link doc reference
-SQLALCHEMY_DOCS_URL = "https://docs.sqlalchemy.org/en/13/core/engines.html"
-SQLALCHEMY_DISPLAY_TEXT = "SQLAlchemy docs"
-
 # Set to False to only allow viewing own recent activity
 ENABLE_BROAD_ACTIVITY_ACCESS = True