fix: small cleanup for created by me dashboards API (#19755)

apache · Apr 20, 2022 · f06db79 · f06db79
1 parent 22a92ed
commit f06db79
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/superset/constants.py b/superset/constants.py
@@ -100,7 +100,6 @@ class RouteMethod:  # pylint: disable=too-few-public-methods
 
 MODEL_API_RW_METHOD_PERMISSION_MAP = {
     "bulk_delete": "write",
-    "created_by_me": "read",
     "delete": "write",
     "distinct": "read",
     "get": "read",

diff --git a/superset/dashboards/api.py b/superset/dashboards/api.py
@@ -140,7 +140,6 @@ def ensure_thumbnails_enabled(self) -> Optional[Response]:
         "set_embedded",
         "delete_embedded",
         "thumbnail",
-        "created_by_me",
     }
     resource_name = "dashboard"
     allow_browser_login = True

diff --git a/superset/views/core.py b/superset/views/core.py
@@ -1587,7 +1587,7 @@ def fave_dashboards(self, user_id: int) -> FlaskResponse:
     @event_logger.log_this
     @expose("/created_dashboards/<int:user_id>/", methods=["GET"])
     def created_dashboards(self, user_id: int) -> FlaskResponse:
-        logging.warning(
+        logger.warning(
             "%s.created_dashboards "
             "This API endpoint is deprecated and will be removed in version 3.0.0",
             self.__class__.__name__,