ok

apache · Mar 13, 2023 · f0af241 · f0af241
1 parent 45a0d2a
commit f0af241
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/superset/tasks/async_queries.py b/superset/tasks/async_queries.py
@@ -91,8 +91,10 @@ def load_chart_data_into_cache(
         except Exception as ex:
             # TODO: QueryContext should support SIP-40 style errors
             error = (
-                ex.message if hasattr(ex, "message") else str(ex)
-            )  # pylint: disable=no-member
+                ex.message  # pylint: disable=no-member
+                if hasattr(ex, "message")
+                else str(ex)
+            )
             errors = [{"message": error}]
             async_query_manager.update_job(
                 job_metadata, async_query_manager.STATUS_ERROR, errors=errors
@@ -160,8 +162,10 @@ def load_explore_json_into_cache(  # pylint: disable=too-many-locals
                 errors = ex.errors  # pylint: disable=no-member
             else:
                 error = (
-                    ex.message if hasattr(ex, "message") else str(ex)
-                )  # pylint: disable=no-member
+                    ex.message  # pylint: disable=no-member
+                    if hasattr(ex, "message")
+                    else str(ex)
+                )
                 errors = [error]
 
             async_query_manager.update_job(

diff --git a/superset/utils/decorators.py b/superset/utils/decorators.py
@@ -45,7 +45,10 @@ def wrapped(*args: Any, **kwargs: Any) -> Any:
                 current_app.config["STATS_LOGGER"].gauge(f"{metric_prefix_}.ok", 1)
                 return result
             except Exception as ex:
-                if hasattr(ex, "status") and ex.status < 500:
+                if (
+                    hasattr(ex, "status")
+                    and ex.status < 500  # pylint: disable=no-member
+                ):
                     current_app.config["STATS_LOGGER"].gauge(
                         f"{metric_prefix_}.warning", 1
                     )

diff --git a/tests/integration_tests/csv_upload_tests.py b/tests/integration_tests/csv_upload_tests.py
@@ -200,7 +200,7 @@ def mock_upload_to_s3(filename: str, upload_prefix: str, table: Table) -> str:
     # only needed for the hive tests
     import docker
 
-    client = docker.from_env()
+    client = docker.from_env()  # type: ignore
     container = client.containers.get("namenode")
     # docker mounted volume that contains csv uploads
     src = os.path.join("/tmp/superset_uploads", os.path.basename(filename))