Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[up coming change]Replace Alert (react-bootstrap -> AntD migration) #12101

Closed
michael-s-molina opened this issue Dec 17, 2020 · 1 comment · Fixed by #12122
Closed

[up coming change]Replace Alert (react-bootstrap -> AntD migration) #12101

michael-s-molina opened this issue Dec 17, 2020 · 1 comment · Fixed by #12122
Assignees
@michael-s-molina

Comments

@michael-s-molina
Copy link
Member

Describe the solution you'd like
Let's replace ALL instances of the Alert component imported from React-bootstrap with the one from AntD.
Remove from LESS files all bootstrap styles that pertain to these alerts.

Additional context
@junlincc @rusackas I'm already working on this.
@michael-s-molina michael-s-molina added the enhancement:request Enhancement request submitted by anyone from the community label Dec 17, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@michael-s-molina michael-s-molina changed the title Replace Bootstrap Alert with Ant.D Alert Replace Alert (react-bootstrap -> AntD migration) Dec 17, 2020
@michael-s-molina michael-s-molina changed the title Replace Alert (react-bootstrap -> AntD migration) [up coming change]Replace Alert (react-bootstrap -> AntD migration) Dec 17, 2020
@michael-s-molina michael-s-molina mentioned this issue Dec 18, 2020
Merged
6 tasks
@junlincc junlincc added upcoming:change:refractor and removed enhancement:request Enhancement request submitted by anyone from the community labels Jan 2, 2021
michael-s-molina added a commit to michael-s-molina/superset that referenced this issue Feb 17, 2021
@michael-s-molina
Migrate Bootstrap Alert to AntD (apache#12101)
3e67ceb
rusackas pushed a commit that referenced this issue Feb 22, 2021
@michael-s-molina
Migrate Bootstrap Alert to AntD (#12101) (#12122)
42ab578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-s-molina michael-s-molina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Bootstrap to AntD - Alert michael-s-molina/superset
2 participants
@junlincc @michael-s-molina