refactor: optimize backend log payload #11927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmud
changed the base branch from
master
to
erik-ritter--remove-logs-columns
ktmud
force-pushed
the
remove--path-no-int
branch
4 times, most recently
from
18c4b85
to
60dd1ee
Compare
Codecov Report
@@ Coverage Diff @@
## master #11927 +/- ##
==========================================
- Coverage 67.55% 63.62% -3.93%
==========================================
Files 957 957
Lines 47002 46992 -10
Branches 4589 4589
==========================================
- Hits 31753 29901 -1852
- Misses 15137 16907 +1770
- Partials 112 184 +72
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ktmud
force-pushed
the
remove--path-no-int
branch
from
2979fe8
to
ee58f18
Compare
ktmud
changed the base branch from
erik-ritter--remove-logs-columns
to
master
ktmud
force-pushed
the
remove--path-no-int
branch
from
ee58f18
to
e94abbd
Compare
ktmud
force-pushed
the
remove--path-no-int
branch
2 times, most recently
from
63db218
to
dbee334
Compare
6 tasks
ktmud
force-pushed
the
remove--path-no-int
branch
3 times, most recently
from
edb3db5
to
788d5e4
Compare
ktmud
changed the title
ktmud
requested review from
mistercrunch,
etr2460 and
john-bodley
and removed request for
mistercrunch
ktmud
force-pushed
the
remove--path-no-int
branch
2 times, most recently
from
1e71b7d
to
72ce5af
Compare
|
@mistercrunch @etr2460 any thoughts on this one? |
ktmud
force-pushed
the
remove--path-no-int
branch
from
72ce5af
to
b905dd1
Compare
ktmud
force-pushed
the
remove--path-no-int
branch
from
b905dd1
to
5ca1d1f
Compare
6 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow up with #11920 and #11714 , implement a more robust
event_loggerpayload.path_no_intwith request.url_rule, the match pattern used in Flask routerrisonobjects when present, and remove the raw query string.ClassName.methodasactionfor REST API and add__qualname__toobject_reffor legacy actions.actionandobject_refin the decoratorslog_manuallytolog_this_with_extra_payloadThe goal is to make future analytic queries on the
logstable as easy as possible and reduce redundancy.cc @mistercrunch @etr2460 @john-bodley @robdiciuccio @dpgaspar @graceguo-supercat
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
Will add unit tests soon
ADDITIONAL INFORMATION