fix: consistent left margin for dashboard layout.

[rusackas]

SUMMARY

Oops! Erroneously merged this to a feature branch instead of master. Ugh.
See #13884 for a history/comments, and prior approvals.

A recent PR, #13723, made some changes around how the sidebar works for the native filter features. This looks great when the feature flag is on, but when the feature flag is off, we lose the left margin, as reported in #13863.

This PR makes sure the styling is consistent, by considering feature flag setting, and only toggling off dashboardFiltersOpen (which sets the margin) when the feature is indeed enabled.

@simcha90 if you have a more elegant way to tackle this, or ideas for sufficient testing to cover this possible regression, please let me know your thoughts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE (DASHBOARD_NATIVE_FILTERS set to False):

AFTER (DASHBOARD_NATIVE_FILTERS set to False):

AFTER (DASHBOARD_NATIVE_FILTERS set to True):

TEST PLAN

Verified that the margin is restored, in view and edit mode, with the DASHBOARD_NATIVE_FILTERS flag on and off.

ADDITIONAL INFORMATION

• Has associated issue: Fixes [dashboard] No left padding in dashboard #13863
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[etr2460]

thanks!

[codecov]

Codecov Report

Merging #13905 (89e2ac2) into master (9d6832d) will increase coverage by 0.21%.
The diff coverage is 86.84%.

❗ Current head 89e2ac2 differs from pull request most recent head 4da64ce. Consider uploading reports for the commit 4da64ce to get more accurate results

@@            Coverage Diff             @@
##           master   #13905      +/-   ##
==========================================
+ Coverage   77.55%   77.77%   +0.21%     
==========================================
  Files         935      935              
  Lines       47301    47303       +2     
  Branches     5907     5916       +9     
==========================================
+ Hits        36685    36788     +103     
+ Misses      10472    10372     -100     
+ Partials      144      143       -1     

Flag	Coverage Δ
cypress	56.03% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...frontend/src/components/DatabaseSelector/index.tsx	92.70% <ø> (+1.04%)	⬆️
...et-frontend/src/components/TableSelector/index.tsx	84.92% <ø> (ø)
...src/dashboard/components/dnd/handleScroll/index.ts	73.33% <ø> (ø)
...re/components/controls/DatasourceControl/index.jsx	86.84% <ø> (ø)
...controls/DndColumnSelectControl/DndSelectLabel.tsx	35.00% <ø> (ø)
...trols/DndColumnSelectControl/components/Option.tsx	50.00% <ø> (ø)
...ents/controls/FilterControl/AdhocFilterControl.jsx	60.00% <ø> (ø)
...Control/AdhocFilterEditPopoverSimpleTabContent.jsx	74.83% <ø> (ø)
...terControl/AdhocFilterEditPopoverSqlTabContent.jsx	63.33% <ø> (ø)
...nents/controls/FilterControl/AdhocFilterOption.jsx	100.00% <ø> (ø)
... and 28 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6832d...4da64ce. Read the comment docs.

[yousoph]

🏷️ 2021.13