-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove supersetTheme with withTheme #17069
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17069 +/- ##
==========================================
+ Coverage 76.91% 77.00% +0.09%
==========================================
Files 1039 1038 -1
Lines 55566 55612 +46
Branches 7570 7585 +15
==========================================
+ Hits 42738 42824 +86
+ Misses 12578 12538 -40
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
This pr removes the supersetTheme with withTheme component.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
Screen.Recording.2021-10-11.at.9.40.39.PM.mov
after
https://user-images.githubusercontent.com/17326228/136892210-bea4877b-8166-4714-9753-64e92af57b23.mov
TESTING INSTRUCTIONS
Go to any chart and go to the datasource panel and click on edit datasource. Check modal looks identical to original.
ADDITIONAL INFORMATION