Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(viz): export csv with verbose_name #17657

Merged
merged 1 commit into from
Dec 8, 2021
Merged

feat(viz): export csv with verbose_name #17657

merged 1 commit into from
Dec 8, 2021

Conversation

chuancyzhang
Copy link
Contributor

@chuancyzhang chuancyzhang commented Dec 6, 2021

The column names displayed on the report are inconsistent with the column names of the actual exported csv file, which can sometimes cause confusion. Therefore, I hope to add a feature to make the column names displayed on the report consistent with the column names of the exported csv file.

SUMMARY

Use verbose_map to help the column names of csv export to be consistent with the front-end display.
Because of the revision of the Superset interface, this PR is changed. #10760

The previous PR was #17341

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE
image
AFTER
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #17657 (724a3b5) into master (2ae83fa) will decrease coverage by 0.34%.
The diff coverage is 100.00%.

❗ Current head 724a3b5 differs from pull request most recent head 1c5727f. Consider uploading reports for the commit 1c5727f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17657      +/-   ##
==========================================
- Coverage   68.85%   68.50%   -0.35%     
==========================================
  Files        1597     1597              
  Lines       65251    65255       +4     
  Branches     6950     6950              
==========================================
- Hits        44927    44703     -224     
- Misses      18439    18667     +228     
  Partials     1885     1885              
Flag Coverage Δ
hive 81.69% <100.00%> (+<0.01%) ⬆️
mysql ?
postgres ?
python 81.69% <100.00%> (-0.77%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/common/query_context_processor.py 91.30% <100.00%> (+0.17%) ⬆️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/views/database/views.py 48.71% <0.00%> (-39.75%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/common/utils/dataframe_utils.py 85.71% <0.00%> (-7.15%) ⬇️
superset/sql_validators/base.py 93.33% <0.00%> (-6.67%) ⬇️
superset/databases/commands/create.py 82.35% <0.00%> (-5.89%) ⬇️
superset/db_engine_specs/sqlite.py 91.89% <0.00%> (-5.41%) ⬇️
superset/views/core.py 73.34% <0.00%> (-4.04%) ⬇️
superset/connectors/sqla/utils.py 88.23% <0.00%> (-3.93%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ae83fa...1c5727f. Read the comment docs.

@zhaoyongjie zhaoyongjie self-requested a review December 6, 2021 09:38
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for CI.

@villebro villebro merged commit 418c0b4 into apache:master Dec 8, 2021
@chuancyzhang chuancyzhang deleted the patch-9 branch December 8, 2021 05:53
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants