Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump FAB to 3.4.3 #17964

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jan 7, 2022

SUMMARY

Bump FAB to 3.4.3 with the following improvements:

fix: openapi on and off config flag (#1770) [Daniel Vaz Gaspar]
fix: data not defined in azure oauth (#1769) [Dalton Pearson]
fix: Handle authorize_access_token exception (#1766) [Michał Konarski]
fix: Set role and confirm password while adding user mandatory (#1758) [Mayur]
fix: required roles on user form not showing error msg (#1772) [Daniel Vaz Gaspar]
fix: make servers be actual servers on swagger, full endpoint paths (#1773) [Daniel Vaz Gaspar]
docs: adds missing config key FAB_OPENAPI_SERVERS (#1776)

TESTING INSTRUCTIONS

Normal Superset bootstrap, verify the security views and DB authentication

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #17964 (db9d62c) into master (3b5cee4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17964   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files        1609     1609           
  Lines       64905    64905           
  Branches     6868     6868           
=======================================
  Hits        43537    43537           
  Misses      19502    19502           
  Partials     1866     1866           
Flag Coverage Δ
hive 53.29% <ø> (ø)
mysql 82.19% <ø> (ø)
postgres 82.24% <ø> (ø)
presto 53.13% <ø> (ø)
python 82.68% <ø> (ø)
sqlite 81.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5cee4...db9d62c. Read the comment docs.

@dpgaspar dpgaspar merged commit ea3a583 into apache:master Jan 7, 2022
@dpgaspar dpgaspar deleted the chore/bump-fab-3-4-3 branch January 7, 2022 14:27
@eschutho eschutho added the v1.4 label Jan 11, 2022
eschutho pushed a commit that referenced this pull request Jan 12, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants