-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deck.gl): multiple layers map size is shrunk #18939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix @stephenLYZ !
Codecov Report
@@ Coverage Diff @@
## master #18939 +/- ##
==========================================
+ Coverage 66.19% 66.38% +0.19%
==========================================
Files 1633 1640 +7
Lines 63210 63514 +304
Branches 6409 6418 +9
==========================================
+ Hits 41839 42164 +325
+ Misses 19711 19690 -21
Partials 1660 1660
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
(cherry picked from commit 2cb3635)
SUMMARY
This PR fixed the problem that map will be shrunk when using deck.gl multiple layer chart.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
Screen.Recording.2022-01-05.at.12.37.59.AM.mov
after
2022-02-25.5.10.18.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION