Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SQL Editor): names new query tabs correctly #18951

Merged
merged 8 commits into from
Mar 4, 2022
Merged

fix(SQL Editor): names new query tabs correctly #18951

merged 8 commits into from
Mar 4, 2022

Commits on Feb 24, 2022

  1. Added in code changes that now properly increment the Untitled Query … 

    …SQL Lab tab names. All that is left is to add tests to make sure that the function works correctly
    @cccs-Dustin
    cccs-Dustin committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    75f6ad7 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. Merge branch 'apache:master' into bug/Fix_SQL_Lab_Add_Query_Button

    @cccs-Dustin
    cccs-Dustin authored Feb 25, 2022
    Configuration menu
    Copy the full SHA
    480bcab View commit details
    Browse the repository at this point in the history

  2. Updated the code so that it adds to the untitled_query_numbers variab… 

    …le only if the character after the string 'Untitled Query ' is a number. This prevents any issues when trying to get the maximum value in the list.
    @cccs-Dustin
    cccs-Dustin committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    8073173 View commit details
    Browse the repository at this point in the history

  3. Refactored part of the mapping code, to make it shorter and easier to… 

    … read/understand
    @cccs-Dustin
    cccs-Dustin committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    b8f0aea View commit details
    Browse the repository at this point in the history

  4. Merge branch 'bug/Fix_SQL_Lab_Add_Query_Button' of github.com:Cyberce… 

    …ntreCanada/superset into bug/Fix_SQL_Lab_Add_Query_Button
    @cccs-Dustin
    cccs-Dustin committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    db84e25 View commit details
    Browse the repository at this point in the history

  5. Fixed issues in the code that were causing some of the CI tests to fail

    @cccs-Dustin
    cccs-Dustin committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    3fcd052 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2022

  1. Made code changes based on comments within the PR. Also added a unit … 

    …test to make sure that the newQueryEditor function in the TabbedSqlEditors component works as intended
    @cccs-Dustin
    cccs-Dustin committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    c49fb7e View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. Fixed the failing cypress test in tabs.test.js

    @cccs-Dustin
    cccs-Dustin committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    7c6b70f View commit details
    Browse the repository at this point in the history