Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade mypy check in pre-commit #19227

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Mar 16, 2022

SUMMARY

CI for pre-commit is suddenly failing. #19156 bypassed it by fixing the error as the mypy hook in pre-commit suggests, but the same error was not reproducible locally. Let's just upgrade the mypy hook to see if the inconsistency between CI and local env persists.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions
Copy link
Contributor

⚠️ @ktmud Your base branch master has just also updated superset/migrations.

Please consider rebasing your branch to avoid db migration conflicts.

@ktmud ktmud force-pushed the pre-commit-upgrade branch 3 times, most recently from a788c6e to 7c71093 Compare March 17, 2022 15:52
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #19227 (16d5f34) into master (4b34817) will increase coverage by 14.62%.
The diff coverage is 81.81%.

❗ Current head 16d5f34 differs from pull request most recent head 8542eaa. Consider uploading reports for the commit 8542eaa to get more accurate results

@@             Coverage Diff             @@
##           master   #19227       +/-   ##
===========================================
+ Coverage   52.11%   66.74%   +14.62%     
===========================================
  Files        1666     1668        +2     
  Lines       64197    64279       +82     
  Branches     6496     6496               
===========================================
+ Hits        33458    42901     +9443     
+ Misses      29057    19696     -9361     
  Partials     1682     1682               
Flag Coverage Δ
hive 52.66% <54.54%> (+<0.01%) ⬆️
mysql 81.98% <81.81%> (?)
postgres 82.01% <81.81%> (?)
presto 52.51% <54.54%> (+<0.01%) ⬆️
python 82.44% <81.81%> (+29.51%) ⬆️
sqlite 81.78% <81.81%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/cli/main.py 0.00% <ø> (ø)
superset/views/core.py 75.77% <33.33%> (+41.10%) ⬆️
superset/charts/data/api.py 89.80% <100.00%> (ø)
superset/models/helpers.py 90.90% <100.00%> (+43.56%) ⬆️
superset/reports/commands/alert.py 96.51% <100.00%> (+62.79%) ⬆️
superset/reports/notifications/base.py 95.83% <100.00%> (+8.33%) ⬆️
superset/utils/async_query_manager.py 82.24% <100.00%> (+10.28%) ⬆️
superset/key_value/commands/update.py 91.48% <0.00%> (ø)
superset/key_value/commands/delete.py 88.88% <0.00%> (ø)
superset/config.py 91.87% <0.00%> (+0.31%) ⬆️
... and 299 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b34817...8542eaa. Read the comment docs.

@ktmud ktmud changed the title chore: upgrade pre-commit hooks and prettier chore: upgrade mypy check in pre-commit Mar 17, 2022
@ktmud ktmud merged commit 92cd0a1 into apache:master Mar 17, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
(cherry picked from commit 92cd0a1)
@john-bodley john-bodley deleted the pre-commit-upgrade branch June 8, 2022 05:33
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants