-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move Database Import option into DB Connection modal #19314
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
2820627
rebase
lyndsiWilliams da40e8d
more progress
lyndsiWilliams bc7ef74
Fix unintended changes
lyndsiWilliams 1a53bdb
DB import goes to step 3
lyndsiWilliams 84dd7f5
debugging
lyndsiWilliams 3a86dea
DB list refreshing properly
lyndsiWilliams c4715da
import screens flowing properly
lyndsiWilliams 14ec320
Code cleanup
lyndsiWilliams bcc9a32
Fixed back button on import flow
lyndsiWilliams c61e0b1
Remove import db tooltip test
lyndsiWilliams 415011e
Fix test
lyndsiWilliams c0da671
Password field resets properly
lyndsiWilliams a5d4761
Changed import modal state dictators and removed unneeded comment
lyndsiWilliams 71ebaf3
Removed unneeded param pass and corrected modal spelling
lyndsiWilliams cb6ef83
Fixed typos
lyndsiWilliams ba13443
Changed file to fileList
lyndsiWilliams f1a7e8b
Clarified import footer comment
lyndsiWilliams aa5b7ea
Cleaned passwordNeededField and confirmOverwriteField state checks
lyndsiWilliams f983649
debugging
lyndsiWilliams 4d1c95a
Import state flow fixed
lyndsiWilliams 1420929
Removed unneeded importModal check in unreachable area
lyndsiWilliams 7c32001
Fixed import db footer behavior when pressing back on step 2
lyndsiWilliams a50e3dd
Import db button now at 14px
lyndsiWilliams 677c546
Removed animation from import db button
lyndsiWilliams a16f98b
Fixed doble-loading successToast
lyndsiWilliams 09ff22a
Fixed errored import behavior
lyndsiWilliams 0bbf890
Updated import password check info box text
lyndsiWilliams e5fc92d
Connect button disables while importing db is loading
lyndsiWilliams 55eedff
Connect button disables while overwrite confirmation is still needed
lyndsiWilliams 48749e4
Connect button disables while password confirmation is still needed
lyndsiWilliams ca6377c
Removed gray line under upload filename
lyndsiWilliams 5a4ee8b
Hide trashcan icon on import filename
lyndsiWilliams 87f4cac
Modal scroll behavior fixed for importing filename
lyndsiWilliams b61afd4
Changed errored to failed
lyndsiWilliams b4c6b6a
RTL testing for db import
lyndsiWilliams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure we don't need this for another test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible, but it wasn't being used for any other tests currently so I wasn't sure if I should keep it. Should I put it back just in case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion is, if we don't need it let's remove it.