WIP- create mixin for chart query #19812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superset-github-bot
bot
added
the
Superset-Community-Partners
Codecov Report
@@ Coverage Diff @@
## master #19812 +/- ##
===========================================
- Coverage 66.53% 53.94% -12.60%
===========================================
Files 1692 1692
Lines 64780 64829 +49
Branches 6661 6661
===========================================
- Hits 43103 34971 -8132
- Misses 19977 28158 +8181
Partials 1700 1700
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eschutho
removed
the
Superset-Community-Partners
eschutho
commented
May 10, 2022
| # def type(self) -> str: | ||
| # return f"{self.__class__.__name__.lower()}" | ||
|
|
||
| type = "query" |
There was a problem hiding this comment.
can we make this more specific like model_type, data_type
There was a problem hiding this comment.
this needs to get moved into the subclass.
eschutho
commented
May 10, 2022
| # def type(self) -> str: | ||
| # return f"{self.__class__.__name__.lower()}" | ||
|
|
||
| type = "query" |
There was a problem hiding this comment.
can we make this more specific like model_type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Per (SIP pending) and #18584 we are in the process of allowing creation of a chart without a dataset. A chart will be able to be created (not saved) by a query, saved query, table, or dataset. This is just step one, chart creation with a query. There is no form data or query context yet.. that will be in a follow up PR.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION