test: make tabbed dashboard a little more complex #19966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmud
commented
May 5, 2022
| @@ -156,7 +156,6 @@ class ChartEntityResponseSchema(Schema): | |||
| slice_name = fields.String(description=slice_name_description) | |||
| cache_timeout = fields.Integer(description=cache_timeout_description) | |||
| changed_on = fields.String(description=changed_on_description) | |||
| modified = fields.String() | |||
There was a problem hiding this comment.
By catch, this field returns invalid strings:
Codecov Report
@@ Coverage Diff @@
## master #19966 +/- ##
===========================================
- Coverage 66.28% 54.35% -11.94%
===========================================
Files 1712 1713 +1
Lines 63968 64063 +95
Branches 6731 6734 +3
===========================================
- Hits 42404 34820 -7584
- Misses 19853 27532 +7679
Partials 1711 1711
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ktmud
force-pushed
the
complex-tabbed-dashboard
branch
from
cffe0c6
to
7880782
Compare
ktmud
commented
May 6, 2022
| "id": "CHART-3nc0d8sk", | ||
| "meta": {"chartId": 50, "height": 50, "sliceName": "Treemap", "width": 8}, | ||
| "type": "CHART", | ||
| }, |
There was a problem hiding this comment.
Bycatch: this is a duplicate slice where the chart component isn't really used in the layout.
ktmud
force-pushed
the
complex-tabbed-dashboard
branch
2 times, most recently
from
21dba14
to
d65f67f
Compare
9 tasks
ktmud
force-pushed
the
complex-tabbed-dashboard
branch
2 times, most recently
from
ef2a103
to
80a67a3
Compare
john-bodley
reviewed
May 10, 2022
ktmud
force-pushed
the
complex-tabbed-dashboard
branch
from
80a67a3
to
e7214f8
Compare
ktmud
force-pushed
the
complex-tabbed-dashboard
branch
from
e7214f8
to
cea3fac
Compare
Postgres has a maximum of 63 characters per table name
|
@john-bodley I added an integration test for |
john-bodley
approved these changes
May 13, 2022
| @@ -54,8 +54,7 @@ def load_examples_run( | |||
| if load_test_data: | |||
| print("Loading [Tabbed dashboard]") | |||
| examples.load_tabbed_dashboard(only_metadata) | |||
|
|
|||
| if not load_test_data: | |||
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Update the test dashboard "Tabbed dashboard" to have more nested tabs so we can test more complex use cases.
Also updated the
update_slice_idsfunction to use dict instead of sorted lists so that slices in position_json can be matched more correctly.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION