Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Make that see more/see less works correctly with scrolling when error msg is long text. #20282

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

prosdev0107
Copy link
Contributor

SUMMARY

[explore] layout - long error messages render funky and don't scroll properly under the data pane

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

AFTER:
image

TESTING INSTRUCTIONS

  1. Go to the explore
  2. Display the long error message in North panel body
  3. The long error message is broken.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #20282 (471e759) into master (6f0d53e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20282   +/-   ##
=======================================
  Coverage   66.65%   66.65%           
=======================================
  Files        1729     1729           
  Lines       64910    64910           
  Branches     6842     6842           
=======================================
  Hits        43268    43268           
  Misses      19893    19893           
  Partials     1749     1749           
Flag Coverage Δ
javascript 51.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/src/explore/components/ExploreChartPanel.jsx 74.19% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f0d53e...471e759. Read the comment docs.

@rusackas rusackas merged commit 1e5cacd into apache:master Jun 8, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants