Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ConditionalFormatting): allow inverse color scaling and add color picker #20353

Closed
wants to merge 18 commits into from
Closed

feat(ConditionalFormatting): allow inverse color scaling and add color picker #20353

wants to merge 18 commits into from

Commits on Jun 11, 2022

  1. fix: converted theme colors to 'rgb(r,g,b)' string

    @stevetracvc
    stevetracvc committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    a368106 View commit details
    Browse the repository at this point in the history

  2. added option to invert the color scale

    @stevetracvc
    stevetracvc committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    e8d9f32 View commit details
    Browse the repository at this point in the history

  3. fix: lint error

    @stevetracvc
    stevetracvc committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    3273fc5 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2022

  1. fix: use minOpacity on inverse

    @stevetracvc
    stevetracvc committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    9e0e498 View commit details
    Browse the repository at this point in the history

  2. new tests for getColorFunction

    @stevetracvc
    stevetracvc committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    1dec457 View commit details
    Browse the repository at this point in the history

  3. inverse doesn't work with equals, added validator

    @stevetracvc
    stevetracvc committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    9457c02 View commit details
    Browse the repository at this point in the history

  4. added test for hexToRGBString

    @stevetracvc
    stevetracvc committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    321e073 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. switched to hexToRgb util

    @stevetracvc
    stevetracvc committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    74b3a4e View commit details
    Browse the repository at this point in the history

  2. switched to color picker

    @stevetracvc
    stevetracvc committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    af5171a View commit details
    Browse the repository at this point in the history

  3. fixed tests and opacity rounding issue

    @stevetracvc
    stevetracvc committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    3b62d53 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. added rgbStringToRgbaObject function to utils so themed green can be … 

    …default in color picker
    @stevetracvc
    stevetracvc committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    65034ca View commit details
    Browse the repository at this point in the history

  2. added sketchPickerWidth prop to make it easier to set popup width

    @stevetracvc
    stevetracvc committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    1be3b45 View commit details
    Browse the repository at this point in the history

  3. fix error on extra escaping

    @stevetracvc
    stevetracvc committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    54fae32 View commit details
    Browse the repository at this point in the history

  4. removed inverse validator, ignored on equals operator

    @stevetracvc
    stevetracvc committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    b78c576 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2022

  1. merged in upstream changes and converted to using hex strings for colors 

    there are a lot of issues associated with moving away from color strings
like `rgb(255, 255, 255)` in favor of `#FFFFFF` (and similar with alpha values).
This fixes a lot of the issues presented, and also provides some extra functions
to help with the transition. Unfortunately there are still too many other components
that are using these rgb strings to convert the color picker right now.
    @stevetracvc
    stevetracvc committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    791d5d2 View commit details
    Browse the repository at this point in the history

  2. copied rgbToHex to avoid dependency issue

    @stevetracvc
    stevetracvc committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    202160c View commit details
    Browse the repository at this point in the history

  3. fixed lint errors

    @stevetracvc
    stevetracvc committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    7cfdea5 View commit details
    Browse the repository at this point in the history

  4. removed optional text on modal

    @stevetracvc
    stevetracvc committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    ca1296a View commit details
    Browse the repository at this point in the history