Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Skip flaky Cypress test #20417

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Conversation

codyml
Copy link
Member

@codyml codyml commented Jun 16, 2022

SUMMARY

The "Datapane loads view samples" test has been failing regularly without cause: based on Cypress dashboard, fail rate is 13% and flaky rate is 36%. This PR skips the test.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #20417 (4d8a280) into master (fadf0ec) will not change coverage.
The diff coverage is n/a.

❗ Current head 4d8a280 differs from pull request most recent head 3d64300. Consider uploading reports for the commit 3d64300 to get more accurate results

@@           Coverage Diff           @@
##           master   #20417   +/-   ##
=======================================
  Coverage   66.70%   66.70%           
=======================================
  Files        1739     1739           
  Lines       65135    65135           
  Branches     6897     6897           
=======================================
  Hits        43450    43450           
  Misses      19932    19932           
  Partials     1753     1753           
Flag Coverage Δ
javascript 51.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fadf0ec...3d64300. Read the comment docs.

@zhaoyongjie zhaoyongjie added the hold:testing! On hold for testing label Jun 17, 2022
@rusackas
Copy link
Member

This is indeed the #1 flaky test according to Cypress dashboard right now. I'm approving in order to unblock other PRs, but it would obviously be great to also follow up here soon with a PR that fixes the test.

image

@rusackas rusackas merged commit 9f74fb7 into apache:master Jun 17, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels hold:testing! On hold for testing preset-io size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants