-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vizgallery): Double-click viz type to submit form #20513
feat(vizgallery): Double-click viz type to submit form #20513
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20513 +/- ##
=======================================
Coverage 66.85% 66.85%
=======================================
Files 1749 1749
Lines 65411 65414 +3
Branches 6906 6907 +1
=======================================
+ Hits 43730 43735 +5
+ Misses 19931 19930 -1
+ Partials 1750 1749 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@stephenLYZ Ephemeral environment spinning up at http://54.188.161.167:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
* Make double-clicking on viz type submit the form. * Add tests.
SUMMARY
This PR streamlines the process of creating a chart or changing a chart's visualization type by allowing the user to double-click a visualization type in the viz type gallery to automatically submit the form. On the AddSlice page, this only works if the user has already selected a dataset.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
/chart/add
.ADDITIONAL INFORMATION