Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly set owners to Sqlatable.owners_data inside payload #20794

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jul 20, 2022

SUMMARY

Updating the data payload to have owners = SqlaTable.owners_data, by accident removed this code and properly refactor and add it back to the core model

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@eric-briscoe eric-briscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and resolves error saving changes to datasets

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #20794 (34cccf9) into master (5a04a28) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 34cccf9 differs from pull request most recent head e3fa8d7. Consider uploading reports for the commit e3fa8d7 to get more accurate results

@@            Coverage Diff             @@
##           master   #20794      +/-   ##
==========================================
- Coverage   66.28%   66.22%   -0.06%     
==========================================
  Files        1757     1757              
  Lines       66795    66796       +1     
  Branches     7052     7052              
==========================================
- Hits        44274    44236      -38     
- Misses      20722    20761      +39     
  Partials     1799     1799              
Flag Coverage Δ
hive 53.24% <100.00%> (+<0.01%) ⬆️
mysql 80.98% <100.00%> (+<0.01%) ⬆️
postgres 81.05% <100.00%> (+<0.01%) ⬆️
presto ?
python 81.37% <100.00%> (-0.12%) ⬇️
sqlite 79.54% <100.00%> (+<0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/connectors/sqla/models.py 89.37% <100.00%> (-0.96%) ⬇️
superset/db_engine_specs/presto.py 84.26% <0.00%> (-4.77%) ⬇️
superset/initialization/__init__.py 89.93% <0.00%> (-1.74%) ⬇️
superset/models/core.py 88.43% <0.00%> (-0.25%) ⬇️
superset/connectors/base/models.py 86.74% <0.00%> (+0.30%) ⬆️

@hughhhh hughhhh merged commit 84b852c into apache:master Jul 20, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.29

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jul 21, 2022
…pache#20794)

* properly set owners_data for sqlatabl

* fix test

(cherry picked from commit 84b852c)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants