Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): UX changes in fast viz switcher #20848

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Jul 25, 2022

SUMMARY

  1. Change icon of "currently rendered chart" from a calendar to a checked square
  2. Change order of charts - move Bar and Area from places 4 and 5 to places 2 and 3
  3. Remove "Visualization type" header - now it will always be visible.

CC @kasiazjc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kasiazjc
Copy link
Contributor

lgtm, thanks! 🚀

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #20848 (9e115b8) into master (644148b) will decrease coverage by 0.02%.
The diff coverage is 48.92%.

❗ Current head 9e115b8 differs from pull request most recent head b3bf9f3. Consider uploading reports for the commit b3bf9f3 to get more accurate results

@@            Coverage Diff             @@
##           master   #20848      +/-   ##
==========================================
- Coverage   66.33%   66.30%   -0.03%     
==========================================
  Files        1756     1757       +1     
  Lines       66769    66862      +93     
  Branches     7059     7078      +19     
==========================================
+ Hits        44288    44334      +46     
- Misses      20684    20719      +35     
- Partials     1797     1809      +12     
Flag Coverage Δ
javascript 51.96% <51.51%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...ages/superset-ui-core/src/query/types/Dashboard.ts 100.00% <ø> (ø)
superset-frontend/src/dashboard/actions/hydrate.js 1.96% <0.00%> (-0.11%) ⬇️
...src/dashboard/components/FiltersBadge/selectors.ts 70.37% <0.00%> (+1.90%) ⬆️
...dashboard/components/SliceHeaderControls/index.tsx 65.88% <0.00%> (+2.35%) ⬆️
...board/components/nativeFilters/FilterBar/index.tsx 60.14% <0.00%> (-0.44%) ⬇️
...nd/src/dashboard/components/nativeFilters/utils.ts 46.66% <ø> (ø)
...perset-frontend/src/dashboard/containers/Chart.jsx 75.00% <ø> (ø)
...set-frontend/src/dashboard/containers/Dashboard.ts 0.00% <ø> (ø)
...shboard/util/charts/getFormDataWithExtraFilters.ts 88.88% <ø> (-5.56%) ⬇️
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! I think we may need a "short name" for chart types, too, so that the ellipses can be avoided (for most use cases at least).

@kgabryje kgabryje merged commit 5c2c2e8 into apache:master Jul 26, 2022
@kgabryje
Copy link
Member Author

Thanks for the updates! I think we may need a "short name" for chart types, too, so that the ellipses can be avoided (for most use cases at least).

I think this problem will at least partially be resolved when we enable GENERIC_CHART_AXES by default - the "Timeseries" prefix will be gone and the main part of chart's name will be visible

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants