Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: making crossFilter.chartsInScope optional #21030

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Aug 9, 2022

SUMMARY

It seems that these ton'g always exist in imported dashboards, which is causing trouble. Hopefully this allows imports to be upgraded to the latest code more smoothly.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

REPRO STEPS:

The above should work without error with this fix, if I'm lucky.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #21030 (11496bd) into master (6650076) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

❗ Current head 11496bd differs from pull request most recent head f464a0e. Consider uploading reports for the commit f464a0e to get more accurate results

@@            Coverage Diff             @@
##           master   #21030      +/-   ##
==========================================
- Coverage   66.35%   66.34%   -0.02%     
==========================================
  Files        1767     1767              
  Lines       67356    67358       +2     
  Branches     7147     7147              
==========================================
- Hits        44694    44686       -8     
- Misses      20834    20844      +10     
  Partials     1828     1828              
Flag Coverage Δ
javascript 52.11% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/dashboard/components/FiltersBadge/selectors.ts 70.37% <0.00%> (ø)
superset/common/query_context_processor.py 88.49% <0.00%> (-0.80%) ⬇️
superset/dao/base.py 95.40% <100.00%> (ø)
superset/explore/utils.py 100.00% <100.00%> (ø)
superset/explore/form_data/commands/utils.py 92.30% <0.00%> (-7.70%) ⬇️
superset/explore/form_data/api.py 89.24% <0.00%> (-6.46%) ⬇️
superset/explore/permalink/api.py 91.37% <0.00%> (-1.73%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@rusackas rusackas merged commit 0042ade into master Aug 9, 2022
@rusackas rusackas deleted the fixing-chart-crossfilter-indicator branch August 9, 2022 18:21
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Aug 9, 2022
@nikhil-kuyya-talentas
Copy link

i am not expert but my observations:

  • !chartConfig.crossFilters.scope.excluded.includes(chartId)
    should this code be rollback ?

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.31 size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants