Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow users to set Tab Title from superset_config.py #21116

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Aug 17, 2022

SUMMARY

Allow users to set Tab Title from superset_config.py

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #21116 (053f4bc) into master (db7e2b2) will decrease coverage by 0.72%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21116      +/-   ##
==========================================
- Coverage   66.27%   65.55%   -0.73%     
==========================================
  Files        1770     1770              
  Lines       67539    67540       +1     
  Branches     7185     7185              
==========================================
- Hits        44764    44277     -487     
- Misses      20936    21424     +488     
  Partials     1839     1839              
Flag Coverage Δ
hive 53.17% <100.00%> (+<0.01%) ⬆️
mysql ?
postgres ?
presto 53.07% <100.00%> (+<0.01%) ⬆️
python 80.00% <100.00%> (-1.50%) ⬇️
sqlite 79.62% <100.00%> (+<0.01%) ⬆️
unit 50.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.50% <100.00%> (+0.02%) ⬆️
superset/datasets/commands/update.py 25.00% <0.00%> (-69.05%) ⬇️
superset/datasets/commands/create.py 29.41% <0.00%> (-68.63%) ⬇️
superset/datasets/commands/delete.py 38.63% <0.00%> (-54.55%) ⬇️
superset/datasets/commands/bulk_delete.py 33.33% <0.00%> (-53.34%) ⬇️
superset/datasets/columns/commands/delete.py 44.11% <0.00%> (-52.95%) ⬇️
superset/datasets/metrics/commands/delete.py 44.11% <0.00%> (-52.95%) ⬇️
superset/datasets/dao.py 44.21% <0.00%> (-50.35%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/datasets/commands/refresh.py 43.75% <0.00%> (-43.75%) ⬇️
... and 27 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hughhhh hughhhh merged commit 642a0d7 into master Aug 18, 2022
hughhhh added a commit that referenced this pull request Aug 30, 2022
This reverts commit 642a0d7.
hughhhh added a commit that referenced this pull request Aug 30, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the config-title branch March 26, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants