Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support trailing slashes in database api #21123

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

Update the database api endpoints so that all custom routes have trailing slashes

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

--

TESTING INSTRUCTIONS

--

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #21123 (a955294) into master (fa0be30) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a955294 differs from pull request most recent head d7149cf. Consider uploading reports for the commit d7149cf to get more accurate results

@@           Coverage Diff           @@
##           master   #21123   +/-   ##
=======================================
  Coverage   66.30%   66.30%           
=======================================
  Files        1772     1772           
  Lines       67613    67613           
  Branches     7205     7205           
=======================================
  Hits        44832    44832           
  Misses      20938    20938           
  Partials     1843     1843           
Flag Coverage Δ
javascript 52.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 60.11% <ø> (ø)
superset-frontend/src/views/CRUD/hooks.ts 46.56% <ø> (ø)
superset/databases/api.py 95.49% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie zhaoyongjie self-requested a review August 22, 2022 07:13
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, It's a safe change, if a user sends a request without trailing then the redirection will be the response.

@zhaoyongjie zhaoyongjie merged commit 15b9f83 into apache:master Aug 22, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants