-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds drill to detail context menu to World Map #21150
feat: Adds drill to detail context menu to World Map #21150
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21150 +/- ##
==========================================
+ Coverage 66.27% 66.29% +0.02%
==========================================
Files 1770 1773 +3
Lines 67543 67655 +112
Branches 7185 7214 +29
==========================================
+ Hits 44764 44855 +91
- Misses 20940 20957 +17
- Partials 1839 1843 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up FEATURE_DRILL_TO_DETAIL=true |
@geido Ephemeral environment spinning up at http://35.92.119.140:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Adds drill-to-detail context menu to World Map chart.
World Map is a legacy plugin with some limitations like re-rendering the whole map from scratch for every property change. That's why you will notice a blinking effect when right-clicking a country or changing the color of the bubbles. Is not the objective of this PR to change this behavior. Another limitation is the possibility of keeping a country in a hovered state when interacting with the context menu. Many of these limitations can be resolved by migrating the World Map to ECharts.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-08-22.at.10.23.34.AM.mov
TESTING INSTRUCTIONS
1 - You should be able to right-click both the country and the bubbles
2 - Check the value and formatted value when right-clicking
3 - When the context menu is active, both labels and hovered effects are disabled for other countries
ADDITIONAL INFORMATION