Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert "Update Tab Name via config (#21116)" #21247

Merged
merged 1 commit into from
Aug 30, 2022
Merged

fix: Revert "Update Tab Name via config (#21116)" #21247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion superset/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@
# "rel": "icon"
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
TAB_TITLE = None


def _try_json_readversion(filepath: str) -> Optional[str]:
Expand Down
1 change: 0 additions & 1 deletion superset/templates/superset/basic.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
{% from 'superset/partials/asset_bundle.html' import css_bundle, js_bundle with context %}

{% set favicons = appbuilder.app.config['FAVICONS'] %}
{% set title = appbuilder.app.config['TAB_TITLE'] %}
<html>
<head>
<title>
Expand Down