Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sqllab): Remove max-width on side panel #21280

Merged

Conversation

justinpark
Copy link
Member

SUMMARY

When a long table option is selected, the selection chip can be overlaps the main editor's panel.
Sometime it can cover the "Run" cta button so hard to run the query.

This commit removes the max-width on sidebar so it can be extended for the overflowing case.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • Before:
sqllab-sidebar--before.mov
  • After:
sqllab-sidebar--after.mov

TESTING INSTRUCTIONS

  • Go to sqllab
  • Choose a long table name option

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@ktmud
Copy link
Member

ktmud commented Aug 31, 2022

Idk, would the users hate it more if too much space for SQL editor was taken over?

Can we maybe render the selected items with ellipses in the middle of text and add a tooltip for full table names?

@ktmud
Copy link
Member

ktmud commented Aug 31, 2022

Something like this

image

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #21280 (fb4d5ee) into master (034ee1c) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21280      +/-   ##
==========================================
- Coverage   66.43%   66.43%   -0.01%     
==========================================
  Files        1784     1784              
  Lines       68185    68189       +4     
  Branches     7265     7265              
==========================================
+ Hits        45298    45300       +2     
- Misses      21018    21020       +2     
  Partials     1869     1869              
Flag Coverage Δ
javascript 52.49% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 61.05% <0.00%> (-0.33%) ⬇️
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 52.87% <0.00%> (ø)
...-frontend/src/components/FilterableTable/index.tsx 72.63% <0.00%> (+0.29%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nytai nytai merged commit 5233a90 into apache:master Sep 1, 2022
@EugeneTorap
Copy link
Contributor

@nytai Why did you merge the PR? We can do it more elegantly.
@ktmud suggested a good idea to clip the text of the selected item and display the full text when hovering over it.
This is a good approach because the width of sidebar doesn't change depending on the long text of the item, the sidebar and sqlEditor always have the same width.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants