Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dataset duplication fatal error #21358

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

reesercollins
Copy link
Contributor

@reesercollins reesercollins commented Sep 7, 2022

SUMMARY

Minor fix for dataset duplication.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

image

TESTING INSTRUCTIONS

Try duplicating a dataset. It should work now.

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Error when duplicating virtual dataset #21281
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #21358 (480de44) into master (ce3d38d) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21358      +/-   ##
==========================================
- Coverage   66.61%   66.59%   -0.03%     
==========================================
  Files        1791     1791              
  Lines       68481    68481              
  Branches     7299     7299              
==========================================
- Hits        45617    45603      -14     
- Misses      20978    20998      +20     
+ Partials     1886     1880       -6     
Flag Coverage Δ
javascript 52.73% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 57.73% <ø> (ø)
...rd/components/nativeFilters/FilterBar/keyValue.tsx 18.51% <0.00%> (-22.23%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 60.14% <0.00%> (-5.80%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reesercollins!

@eschutho
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://35.86.77.230:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@sadpandajoe
Copy link
Member

LGTM

@EugeneTorap
Copy link
Contributor

@eschutho Can you update the description and write 'Fix #21281' to auto close the GitHub issue?

@eschutho eschutho merged commit e3ddd0b into apache:master Sep 27, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Oct 3, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.39

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when duplicating virtual dataset
5 participants