-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check that imports are ZIPs #21875
Conversation
@@ -289,7 +289,7 @@ const ImportModelsModal: FunctionComponent<ImportModelsModalProps> = ({ | |||
name="modelFile" | |||
id="modelFile" | |||
data-test="model-file-input" | |||
accept=".yaml,.json,.yml,.zip" | |||
accept=".yaml,.json,.yml,.zip,.pdf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to remove this.
Codecov Report
@@ Coverage Diff @@
## master #21875 +/- ##
==========================================
+ Coverage 66.90% 66.91% +0.01%
==========================================
Files 1805 1806 +1
Lines 69081 69163 +82
Branches 7378 7391 +13
==========================================
+ Hits 46218 46283 +65
- Misses 20953 20969 +16
- Partials 1910 1911 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
7f45389
to
999c82a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after removing the frontend change, also can you add a test also?
6007d34
to
a9490b9
Compare
SUMMARY
Check that imports are actually ZIP files.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
TESTING INSTRUCTIONS
Working on unit tests.
ADDITIONAL INFORMATION