chore: rename 'Change dataset' action to 'Swap dataset' #22197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We received feedback around the two options (right above/under one another in a dropdown action list in explore) labeled `Edit dataset` and `Change dataset` are confusing. This PR renames `Change dataset` to `Swap dataset`, which is more clear about the actual action taking place. We considered other options like: `Swith dataset` or `Point to another dataset` and felt like `Swap dataset` was shorter/clearer. We also consider re-labeling `Edit dataset` to `Edit dataset properties` but felt it was long and unecessary.
Codecov Report
@@ Coverage Diff @@
## master #22197 +/- ##
=======================================
Coverage 65.49% 65.49%
=======================================
Files 1835 1835
Lines 69927 69927
Branches 7590 7590
=======================================
Hits 45802 45802
Misses 22159 22159
Partials 1966 1966
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
/testenv up |
|
@lyndsiWilliams Ephemeral environment spinning up at http://35.162.54.145:8080. Credentials are |
|
Ephemeral environment shutdown and build artifacts deleted. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We received feedback around the two options (right above/under one another in a dropdown action list in explore) labeled
Edit datasetandChange datasetare confusing. This PR renamesChange datasettoSwap dataset, which is more clear about the actual action taking place.We considered other options like:
Switch datasetorPoint to another datasetand felt likeSwap datasetwas shorter/clearer.We also consider re-labeling
Edit datasettoEdit dataset propertiesbut felt it was long and unnecessary.