fix(plugin-chart-echarts): tooltip overflow bug

[villebro]

SUMMARY

This fixes a regression from #22082 which caused the tooltip to become cut when overflowing the chart DOM element. By making sure all tooltips have the appendToBody (see: https://echarts.apache.org/en/option.html#tooltip.appendToBody) property set to true we can ensure overflowing is handled correctly on all ECharts plugins.

When reviewing the PR, make sure to use "hide whitespace", as the changes to the tooltip position function are all indentation changes.

AFTER

Now overflowing works as expected:

overflow-after.mp4

BEFORE

Previously overflowing on certain charts caused the tooltip to be cut:

overflow-before.mp4

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[zhaoyongjie]

/testenv up

[github-actions]

@zhaoyongjie Container image not yet published for this PR. Please try again when build is complete.

[github-actions]

@zhaoyongjie Ephemeral environment creation failed. Please check the Actions logs for details.

[zhaoyongjie]

/testenv up

[github-actions]

@zhaoyongjie Ephemeral environment spinning up at http://52.12.29.135:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[codecov]

Codecov Report

Merging #22218 (1a419d3) into master (3bc0865) will not change coverage.
The diff coverage is 11.11%.

@@           Coverage Diff           @@
##           master   #22218   +/-   ##
=======================================
  Coverage   66.92%   66.92%           
=======================================
  Files        1835     1835           
  Lines       69988    69988           
  Branches     7612     7612           
=======================================
  Hits        46839    46839           
  Misses      21183    21183           
  Partials     1966     1966           

Flag	Coverage Δ
javascript	53.75% <11.11%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...BigNumber/BigNumberWithTrendline/transformProps.ts	47.82% <ø> (ø)
...plugin-chart-echarts/src/BoxPlot/transformProps.ts	55.00% <ø> (ø)
.../plugin-chart-echarts/src/Funnel/transformProps.ts	72.34% <ø> (ø)
...s/plugin-chart-echarts/src/Gauge/transformProps.ts	77.21% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts	0.00% <ø> (ø)
...ins/plugin-chart-echarts/src/Pie/transformProps.ts	55.71% <ø> (ø)
...s/plugin-chart-echarts/src/Radar/transformProps.ts	0.00% <ø> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts	52.27% <ø> (ø)
...ns/plugin-chart-echarts/src/Tree/transformProps.ts	81.81% <ø> (ø)
...plugin-chart-echarts/src/Treemap/transformProps.ts	52.23% <ø> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[kgabryje]

LGTM, tested the fix + verified that the old bug isn't reintroduced.

[zhaoyongjie]

Tested, LGTM

[zhaoyongjie]

There is an issue unrelated to this PR but label related when I test this. @jinghua-qa

label.in.Pie.mov

[villebro]

There is an issue unrelated to this PR but label related when I test this. @jinghua-qa

@zhaoyongjie this bug seems to be unrelated to this PR (I was able to repro on master), but I can look into it in a separate PR.

Edit: This is a regression on the current stable version of ECharts and has been fixed here: apache/echarts#17715

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.