Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dashboard): Fix missing React key errors #22266

Merged
merged 1 commit into from
Nov 30, 2022
Merged

chore(dashboard): Fix missing React key errors #22266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ const FilterControls: FC<FilterControlsProps> = ({
const renderer = useCallback(
({ id }: Filter | Divider) => {
const index = filtersWithValues.findIndex(f => f.id === id);
return <OutPortal node={portalNodes[index]} inView />;
return <OutPortal key={id} node={portalNodes[index]} inView />;
},
[filtersWithValues, portalNodes],
);
Expand Down Expand Up @@ -202,7 +202,7 @@ const FilterControls: FC<FilterControlsProps> = ({
{portalNodes
.filter((node, index) => filterIds.has(filtersWithValues[index].id))
.map((node, index) => (
<InPortal node={node}>
<InPortal node={node} key={filtersWithValues[index].id}>
{filterControlFactory(
index,
filterBarOrientation,
Expand Down
4 changes: 3 additions & 1 deletion superset-frontend/src/dashboard/components/nativeFilters/FilterCard/ScopeRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ export const ScopeRow = React.memo(({ filter }: FilterCardRowProps) => {
? Object.values(scope)
.flat()
.map((element, index) => (
<span>{index === 0 ? element : `, ${element}`}</span>
<span key={element}>
{index === 0 ? element : `, ${element}`}
</span>
))
: t('None')}
</RowValue>
Expand Down