Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add columns back into SQL Lab to Explore Flow #22320

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Dec 2, 2022

SUMMARY

Columns were lost when SQL lab was refactored in the last month, it is now its own separate prop, and we need to rebuild the query object when it is updated. This PR adds columns back to the query model so that when we open the save dataset modal that it is present.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-12-02.at.2.55.57.PM.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@AAfghahi AAfghahi force-pushed the arash.afghahi/sc-62358/chart-in-explore-columns-are-missing-from branch from 9456586 to d89ffdf Compare December 2, 2022 22:03
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #22320 (a1153a6) into master (997950e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22320   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files        1847     1847           
  Lines       70482    70482           
  Branches     7721     7721           
=======================================
  Hits        47120    47120           
  Misses      21362    21362           
  Partials     2000     2000           
Flag Coverage Δ
hive 52.53% <ø> (ø)
javascript 53.77% <ø> (ø)
mysql 77.96% <ø> (ø)
postgres 78.02% <ø> (ø)
presto 52.42% <ø> (ø)
python 81.23% <ø> (ø)
sqlite 76.48% <ø> (ø)
unit 50.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/SaveQuery/index.tsx 75.55% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yousoph
Copy link
Member

yousoph commented Dec 2, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

@yousoph Ephemeral environment spinning up at http://54.191.121.186:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.. Can you write a test, too?

@AAfghahi
Copy link
Member Author

AAfghahi commented Dec 2, 2022

@eschutho of course!

@AAfghahi AAfghahi force-pushed the arash.afghahi/sc-62358/chart-in-explore-columns-are-missing-from branch from d89ffdf to 2aebb07 Compare December 5, 2022 16:21
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Dec 5, 2022
@AAfghahi AAfghahi force-pushed the arash.afghahi/sc-62358/chart-in-explore-columns-are-missing-from branch from 2aebb07 to cab248b Compare December 5, 2022 16:28
@pull-request-size pull-request-size bot added size/S and removed size/M labels Dec 5, 2022
@AAfghahi AAfghahi force-pushed the arash.afghahi/sc-62358/chart-in-explore-columns-are-missing-from branch 4 times, most recently from fcde51b to 6c7a30e Compare December 5, 2022 18:03
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Dec 5, 2022
@AAfghahi AAfghahi force-pushed the arash.afghahi/sc-62358/chart-in-explore-columns-are-missing-from branch from 6c7a30e to a1153a6 Compare December 5, 2022 18:03
@AAfghahi AAfghahi merged commit 5e1b817 into master Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the arash.afghahi/sc-62358/chart-in-explore-columns-are-missing-from branch March 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants