Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DropdownContainer items width calculation #22371

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Updates DropdownContainer to correctly calculate the width of the items when the items property changes.
Previously, the width calculation was only considering visible items which lead to resizing errors.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-12-08.at.9.24.46.AM.mov
Screen.Recording.2022-12-08.at.9.21.49.AM.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #22371 (9a79dbe) into master (f64423a) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

❗ Current head 9a79dbe differs from pull request most recent head ef12db6. Consider uploading reports for the commit ef12db6 to get more accurate results

@@            Coverage Diff             @@
##           master   #22371      +/-   ##
==========================================
- Coverage   66.87%   66.86%   -0.01%     
==========================================
  Files        1847     1847              
  Lines       70561    70559       -2     
  Branches     7739     7739              
==========================================
- Hits        47186    47178       -8     
- Misses      21374    21381       +7     
+ Partials     2001     2000       -1     
Flag Coverage Δ
javascript 53.82% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/components/DropdownContainer/index.tsx 64.55% <33.33%> (-8.29%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@codyml codyml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked locally for me, LGTM!

@michael-s-molina michael-s-molina merged commit 1edfd7e into apache:master Dec 8, 2022
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Dec 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.49 size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants