fix(ssh-tunnel): fix dataset creation flow through modal for DB with tunnel

[hughhhh]

SUMMARY

DB's with tunnels are failing to create datasets, put in a fix to use context manager whenever checking on physical tables.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #22581 (ed83d51) into master (db20180) will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #22581      +/-   ##
==========================================
+ Coverage   67.00%   67.02%   +0.01%     
==========================================
  Files        1859     1859              
  Lines       71036    71037       +1     
  Branches     7766     7766              
==========================================
+ Hits        47597    47609      +12     
+ Misses      21417    21406      -11     
  Partials     2022     2022              

Flag	Coverage Δ
hive	52.47% <66.66%> (+<0.01%)	⬆️
javascript	53.85% <ø> (ø)
mysql	78.01% <66.66%> (?)
postgres	78.09% <66.66%> (+<0.01%)	⬆️
presto	52.37% <66.66%> (+<0.01%)	⬆️
python	81.35% <66.66%> (+0.03%)	⬆️
sqlite	76.46% <66.66%> (+<0.01%)	⬆️
unit	51.47% <33.33%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/models/core.py	90.49% <66.66%> (+0.66%)	⬆️
superset/views/core.py	74.98% <0.00%> (+0.22%)	⬆️
superset/db_engine_specs/mysql.py	98.80% <0.00%> (+4.76%)	⬆️
superset/common/utils/dataframe_utils.py	95.23% <0.00%> (+4.76%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[zhaoyongjie]

@hughhhh I think we should try to avoid this intrusive coding style, this context function has modified too much logic, you should redesign this function.

[hughhhh]

@hughhhh I think we should try to avoid this intrusive coding style, this context function has modified too much logic, you should redesign this function.

why do you think it's intrusive?

This pattern is the cleanest way for us to support ssh tunnel in my opinion since we have to build the tunnel within context for any request to query the db

[Antonio-RiveroMartnez]

LGTM!

[craig-rueda]

Is there a way to test this?

[sadpandajoe]

🏷️ preset:2023.01